Skip to content

fix(ui-side-nav-bar): show focus ring on selected item#2613

Open
ToMESSKa wants to merge 2 commits into
masterfrom
INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7
Open

fix(ui-side-nav-bar): show focus ring on selected item#2613
ToMESSKa wants to merge 2 commits into
masterfrom
INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7

Conversation

@ToMESSKa

@ToMESSKa ToMESSKa commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

INSTUI-5078

ISSUE:

  • the selected item in SideNavBar (v2) showed no focus ring when focused — the a11y team flagged that users couldn't tell which item was selected/focused
  • @instructure/instructure-design-tokens needs to be bumped as the corresponding token needed to be updated too

TEST PLAN:

  • check the example in the v2 version of the SideNavBar in the 4 different themes
  • using the Tab, go through the SideNavBar items, each item should have a visible focus ring including the selected "Dashboard" element

@ToMESSKa ToMESSKa self-assigned this Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://instructure.design/pr-preview/pr-2613/

Built to branch gh-pages at 2026-07-21 10:24 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions

github-actions Bot commented Jun 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Visual regression report

⚠️ Changes detected.

Status Count
Unchanged 31
Changed 1
New 0
Removed 0

📊 View full report

Diff images (1)

badge.png — 8155 pixels differ

Baselines come from the visual-baselines branch. They refresh on every merge to master.

github-actions Bot pushed a commit that referenced this pull request Jun 26, 2026
@ToMESSKa
visual-regression: PR #2613 (b33de82) b33de82
bc39fbc
@ToMESSKa
ToMESSKa force-pushed the INSTUI-5078-focusring-is-not-visible-on-the-selected-side-navbar-item-in-11-7 branch from dd8aa5c to e9ede98 Compare July 21, 2026 10:21
github-actions Bot pushed a commit that referenced this pull request Jul 21, 2026
@ToMESSKa
visual-regression: PR #2613 (efde465) efde465
0364204
@ToMESSKa
ToMESSKa requested a review from matyasf July 21, 2026 11:13
@ToMESSKa
ToMESSKa marked this pull request as ready for review July 21, 2026 11:14
@matyasf
matyasf requested a review from HerrTopi July 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matyasf matyasf matyasf approved these changes
@HerrTopi HerrTopi HerrTopi approved these changes

Assignees

@ToMESSKa ToMESSKa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ToMESSKa @matyasf @HerrTopi